[CI] fix hardcode in TestImageHistory #4083
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix hardcoded
CreatedSince
values in TestImageHistory .Related Issue
#4067
Change
Replaced the fixed string value used in
assert.Equal
for theCreatedSince
field with the value returned by theformatter.TimeSinceInHuman
function in relevant unit test cases.Added a unit test case for the
formatter.TimeSinceInHuman
function .Others
I noticed that other functions in
formatter.go
seem to have no unit tests . There may be a risk when these functions are changed .