[CI]: fix internal command flaky test (window) #4114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apostasie <[email protected]>
|
Kube failure is #4106 (working on it in another PR). |
This was referenced Apr 17, 2025
AkihiroSuda
approved these changes
Apr 18, 2025
AkihiroSuda
added
area/ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, commands that time-out occasionally have exit code set to 1 instead of (expected) -1.
It is not clear why - intuition is that golang command cancellation on context timeout might not be fully deterministic.
Also, it does not matter, as on timeout there is no reason to check error code, so, this PR just relaxes the test.