fix: reworked fine-tuning button in about section #2853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmaury
requested changes
Apr 14, 2025
packages/backend/package.json
Outdated
| @@ -55,7 +55,7 @@ | |||
| "type": "boolean", | |||
| "default": false, | |||
| "description": "Display InstructLab Tuning screens (experimental)", | |||
| "hidden": true | |||
| "hidden": false | |||
There was a problem hiding this comment.
It should be kept hidden as it is not fully implemented
There was a problem hiding this comment.
I understand. So in that case can we hide the fine-tuning button on the instructlab about page since the issue above describes it leading to a blank screen since experimentalTuning is hidden
benoitf
reviewed
Apr 17, 2025
bmahabirbu
force-pushed
the
finetune-fix
branch
from
f11c635 to
3a169ce
Compare
bmahabirbu
changed the title
|
Updated! |
axel7083
approved these changes
Apr 22, 2025
jeffmaury
approved these changes
Apr 23, 2025
bmahabirbu
force-pushed
the
finetune-fix
branch
2 times, most recently
from
a1d920c to
b2453ea
Compare
Signed-off-by: Brian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the issue where clicking on the fine-tune button will lead to a blank page
Now I reworked the button so that it will enable the setting in experimental feature for fine tuning
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #2665
How to test this PR?
(have both folders in the same directory)
pnpm watch (in podman ai lab)
pnpm watch --extension-folder ../podman-desktop-extension-ai-lab/packages/backend (in podman desktop)