Fixed testcase assertions to be env agnostic #184
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
reeshika-h
commented
Apr 23, 2025
reeshika-h
commented
- Refactor assertions in tests to use assertNotNull for improved validation
- Introduced SanityReport class to generate test summaries and send reports to Slack. - Updated logging in CSHttpConnection to use logger instead of printStackTrace. - Modified error handling in Entry class to check for empty error messages. - Updated dependency versions in pom.xml and added new dependencies. - Added test configuration properties to .gitignore. - Created send-report.sh script for running tests and sending reports.
AniketDev7
previously approved these changes
May 5, 2025
| @@ -103,7 +103,7 @@ private void includeLivePreview() { | |||
| if (config.enableLivePreview) { | |||
| String urlLivePreview = config.livePreviewHost; | |||
| if(config.region != null && !config.region.name().isEmpty()){ | |||
| if(config.region.name() == "US" ){ | |||
| if(config.region.name().equals("US") ){ | |||
There was a problem hiding this comment.
Can u please check if the value US is valid or not? For NA region. The known valid values were NA / AWS-NA
There was a problem hiding this comment.
well by default it does take the NA host. This US check is being made in live preview functionality
| @@ -69,23 +69,28 @@ public void onCompletion(ResponseType responseType, Error error) { | |||
| logger.info("passed.."); | |||
| } | |||
|
|
|||
| //pass variant uid | |||
| @Disabled | |||
There was a problem hiding this comment.
If we don't pass the variantsUID the test will fail. Hence disabled the tests.
There was a problem hiding this comment.
The other test cases are live preview which cannot be validated(2 tests), and remaining 2tests are of synchronisation which requires pagination token hence disabled.
In total 6 tests are disabled. I have enabled one testcase.
…remove disabled test for asset URL update
…ests in TestLivePreview and TestStack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.