-
Notifications
You must be signed in to change notification settings - Fork 2.9k
tests for uriToFile #5584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests for uriToFile #5584
Conversation
✅ Deploy Preview for continuedev canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some conflicts
Awesome! Please also add support for WSL paths, which start with |
@sestinj note merge conflicts |
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
@YetiCGN Thanks for calling that out! I was actually originally testing this change on WSL, so can report that it is already working. I added tests so we make sure it stays working |
Description
Adding a safer URI parsing function, including tests. This is intended to solve URI-related bugs that cause major problems for JetBrains in WSL
Checklist
Summary by mrge
Added a safer uriToFile function and new tests to handle file URI parsing, fixing issues with special characters and query parameters.