Skip to content

tests for uriToFile #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 16, 2025
Merged

tests for uriToFile #5584

merged 5 commits into from
May 16, 2025

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented May 9, 2025

Description

Adding a safer URI parsing function, including tests. This is intended to solve URI-related bugs that cause major problems for JetBrains in WSL

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Summary by mrge

Added a safer uriToFile function and new tests to handle file URI parsing, fixing issues with special characters and query parameters.

  • Bug Fixes
    • Handles URIs with spaces, special characters, and query parameters.
    • Improves reliability for JetBrains on WSL.

@sestinj sestinj requested a review from a team as a code owner May 9, 2025 07:01
@sestinj sestinj requested review from RomneyDa and removed request for a team May 9, 2025 07:01
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 9, 2025
Copy link

netlify bot commented May 9, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 67671f4
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/68253055ac45850008f5eab3

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 9, 2025
RomneyDa
RomneyDa previously approved these changes May 12, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some conflicts

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 12, 2025
@YetiCGN
Copy link

YetiCGN commented May 12, 2025

Awesome! Please also add support for WSL paths, which start with \\wsl$ or \\wsl.localhost. See #4135 for more on this.

@RomneyDa
Copy link
Collaborator

@sestinj note merge conflicts

Copy link

github-actions bot commented May 14, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sestinj
Copy link
Contributor Author

sestinj commented May 15, 2025

I have read the CLA Document and I hereby sign the CLA

@sestinj
Copy link
Contributor Author

sestinj commented May 15, 2025

recheck

github-actions bot added a commit that referenced this pull request May 15, 2025
@sestinj
Copy link
Contributor Author

sestinj commented May 15, 2025

@YetiCGN Thanks for calling that out! I was actually originally testing this change on WSL, so can report that it is already working. I added tests so we make sure it stays working

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 15, 2025
@RomneyDa RomneyDa merged commit a56a4dc into main May 16, 2025
35 of 37 checks passed
@RomneyDa RomneyDa deleted the nate/intellij-uri-tests branch May 16, 2025 20:03
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs May 16, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants