Skip to content

perf(rules): optimize header-trim #4363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Apr 9, 2025

Description

Optimizes header-trim rule to perform better. Comparing a string to another string is an unnecessary cost in this case.

I also replaced the switch/case with plain ifs, which are simpler.

Motivation and Context

I just happened to see the code, and noticed it could be improved.

Usage examples

N/A

How Has This Been Tested?

Existing tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codesandbox-ci bot commented Apr 9, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat
Copy link
Member

Can you run yarn format-fix to get it green? Thanks

@felipecrs
Copy link
Contributor Author

@escapedcat, done, thank you!

@escapedcat escapedcat merged commit b7e404b into conventional-changelog:master Apr 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants