Skip to content

Commit ee58f89

Browse files
danehanscoolkp
authored andcommitted
Updates EPP Deployment and Release Doc/Script (kubernetes-sigs#322)
* Changes EPP ImagePullPolicy Signed-off-by: Daneyon Hansen <[email protected]> * Updates release doc and script Signed-off-by: Daneyon Hansen <[email protected]> --------- Signed-off-by: Daneyon Hansen <[email protected]>
1 parent 3631516 commit ee58f89

File tree

3 files changed

+16
-11
lines changed

3 files changed

+16
-11
lines changed

.github/ISSUE_TEMPLATE/new-release.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ This document defines the process for releasing Gateway API Inference Extension.
3434
export RC=1
3535
```
3636

37-
4. The vLLM image tag defaults to `v0.7.1` for a release. Optionally, change the vLLM image tag. For example:
37+
4. The vLLM image tag defaults to `0.7.2` for a release. Optionally, change the vLLM image tag. For example:
3838

3939
```shell
40-
export VLLM=0.7.2
40+
export VLLM=0.7.3
4141
```
4242

4343
## Release Process
@@ -114,7 +114,8 @@ This document defines the process for releasing Gateway API Inference Extension.
114114

115115
9. Pushing the tag triggers Prow to build and publish the container image to the [staging registry][].
116116
10. Submit a PR against [k8s.io][] to add the staging image tag and SHA to [`k8s-staging-gateway-api-inference-extension/images.yaml`][yaml]. This will
117-
promote the image to the production registry. **Note:** Add a link to this issue when the PR is merged.
117+
promote the image to the production registry, e.g. `registry.k8s.io/gateway-api-inference-extension/epp:v${MAJOR}.${MINOR}.0`.
118+
**Note:** Add a link to this issue when the PR is merged.
118119
11. Test the steps in the tagged quickstart guide after the PR merges, for example: `https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/v0.1.0-rc.1/pkg/README.md`.
119120
12. Create a [new release][]:
120121
1. Choose the tag that you created for the release.

hack/release-quickstart.sh

+11-8
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ else
1515
RELEASE_TAG="v${MAJOR}.${MINOR}.0-rc.${RC}"
1616
fi
1717

18-
# vLLM image version (default to 0.7.1 if not defined)
19-
VLLM="${VLLM:-0.7.1}"
18+
# vLLM image version (default to 0.7.2 if not defined)
19+
VLLM="${VLLM:-0.7.2}"
2020

2121
echo "Using release tag: ${RELEASE_TAG}"
2222
echo "Using vLLM image version: ${VLLM}"
@@ -41,23 +41,26 @@ sed -i.bak "s|kubectl apply -k https://github.com/kubernetes-sigs/gateway-api-in
4141
EXT_PROC="pkg/manifests/ext_proc.yaml"
4242
echo "Updating ${EXT_PROC} ..."
4343

44-
# Update any image reference for the EPP container.
45-
# For images from registry.k8s.io:
46-
sed -i.bak -E "s|(registry\.k8s\.io/gateway-api-inference-extension/epp:)[^\"[:space:]]+|\1${RELEASE_TAG}|g" "$EXT_PROC"
47-
# In case there is still any reference from us-central1-docker.pkg.dev:
44+
# Update the EPP container tag.
4845
sed -i.bak -E "s|(us-central1-docker\.pkg\.dev/k8s-staging-images/gateway-api-inference-extension/epp:)[^\"[:space:]]+|\1${RELEASE_TAG}|g" "$EXT_PROC"
4946

47+
# Update the EPP container image pull policy.
48+
sed -i.bak '/us-central1-docker.pkg.dev\/k8s-staging-images\/gateway-api-inference-extension\/epp/ { n; s/Always/IfNotPresent/ }' "$EXT_PROC"
49+
50+
# Update the EPP container registry.
51+
sed -i.bak -E "s|us-central1-docker\.pkg\.dev/k8s-staging-images|registry.k8s.io|g" "$EXT_PROC"
52+
5053
# -----------------------------------------------------------------------------
5154
# Update pkg/manifests/vllm/deployment.yaml
5255
# -----------------------------------------------------------------------------
5356
VLLM_DEPLOY="pkg/manifests/vllm/deployment.yaml"
5457
echo "Updating ${VLLM_DEPLOY} ..."
5558

5659
# Update the vLLM image version
57-
sed -i.bak -E "s|(vllm/vllm-openai:)[^\"[:space:]]+|\1${VLLM}|g" "$VLLM_DEPLOY"
60+
sed -i.bak -E "s|(vllm/vllm-openai:)[^\"[:space:]]+|\1v${VLLM}|g" "$VLLM_DEPLOY"
5861

5962
# Also change the imagePullPolicy from Always to IfNotPresent on lines containing the vLLM image.
60-
sed -i.bak "/vllm\/vllm-openai/ s/Always/IfNotPresent/g" "$VLLM_DEPLOY"
63+
sed -i.bak '/vllm\/vllm-openai/ { n; s/Always/IfNotPresent/ }' "$VLLM_DEPLOY"
6164

6265
# -----------------------------------------------------------------------------
6366
# Stage the changes

pkg/manifests/ext_proc.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ spec:
7272
containers:
7373
- name: inference-gateway-ext-proc
7474
image: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp:main
75+
imagePullPolicy: Always
7576
args:
7677
- -poolName
7778
- "vllm-llama2-7b-pool"

0 commit comments

Comments
 (0)