Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates EPP Deployment and Release Doc/Script #322

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Updates EPP Deployment and Release Doc/Script #322

merged 2 commits into from
Feb 11, 2025

Conversation

danehans
Copy link
Contributor

  • Revert "Replace EndpointSlice reconciler with pod list backed by informers" #301 reverted EPP changes from a different PR. Since the EPP image was already loaded in my cluster nodes, e2e failed due to CLI flag changes in the reverted PR. For the main branch, the EPP imagePullPolicy should be Always to ensure cached images are not being used.
  • Updates release script to use correct and latest vLLM image.
  • Updates release script to use production instead of staging image registry.

@danehans
Changes EPP ImagePullPolicy
c7049ed 
Signed-off-by: Daneyon Hansen <[email protected]>
@danehans
Updates release doc and script
14262f3 
Signed-off-by: Daneyon Hansen <[email protected]>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 11, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 11, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 14262f3
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67ab95fc8429590008f7a01a
😎 Deploy Preview https://deploy-preview-322--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 11, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 70b5c84 into kubernetes-sigs:main Feb 11, 2025
8 checks passed
coolkp pushed a commit to coolkp/llm-instance-gateway that referenced this pull request Feb 13, 2025
@danehans @coolkp
Updates EPP Deployment and Release Doc/Script (kubernetes-sigs#322)
ee58f89 
* Changes EPP ImagePullPolicy

Signed-off-by: Daneyon Hansen <[email protected]>

* Updates release doc and script

Signed-off-by: Daneyon Hansen <[email protected]>

---------

Signed-off-by: Daneyon Hansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danehans @k8s-ci-robot @ahg-g