Revert "mantle: make kola use ecdsa SSH keys" #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5c036d1. That commit broke `kola` on AWS, because that platform only supports RSA keys.
35 tasks
travier
approved these changes
Oct 6, 2020
|
The most likely fix would be finding out why the current code create rsa-sha1 keys (as mentioned in #1749 (comment)) to be able to keep RSA keys for AWS support. |
|
fun. |
|
Let's get this round of releases out and then we can re-attempt to solve this problem for f33. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, lucab, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
34 tasks
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
Oct 6, 2020
… f33 For F33 let's re-enable RSA-SHA1 keys for now so our kola tests will work. The plan is to only re-enable this briefly while we wait for an upstream feature [1] to be implemented. We had moved to an ecdsa key [2] but AWS doesn't support non RSA keys [3] so we reverted it for now in [4]. [1] golang/go#37278 (comment) [2] coreos/coreos-assembler#1749 [3] https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-key-pairs.html#how-to-generate-your-own-key-and-import-it-to-aws [4] coreos/coreos-assembler#1767
dustymabe
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Oct 6, 2020
… f33 For F33 let's re-enable RSA-SHA1 keys for now so our kola tests will work. The plan is to only re-enable this briefly while we wait for an upstream feature [1] to be implemented. We had moved to an ecdsa key [2] but AWS doesn't support non RSA keys [3] so we reverted it for now in [4]. [1] golang/go#37278 (comment) [2] coreos/coreos-assembler#1749 [3] https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-key-pairs.html#how-to-generate-your-own-key-and-import-it-to-aws [4] coreos/coreos-assembler#1767
kelvinfan001
pushed a commit
to kelvinfan001/fedora-coreos-config
that referenced
this pull request
Dec 14, 2020
… f33 For F33 let's re-enable RSA-SHA1 keys for now so our kola tests will work. The plan is to only re-enable this briefly while we wait for an upstream feature [1] to be implemented. We had moved to an ecdsa key [2] but AWS doesn't support non RSA keys [3] so we reverted it for now in [4]. [1] golang/go#37278 (comment) [2] coreos/coreos-assembler#1749 [3] https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-key-pairs.html#how-to-generate-your-own-key-and-import-it-to-aws [4] coreos/coreos-assembler#1767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5c036d1.
That commit broke
kolaon AWS, because that platform only supportsRSA keys.
Ref: #1749 (comment)
/cc @dustymabe @jlebon