Skip to content

Add marker comments in pages? #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mvelosop
Copy link
Contributor

Hi @mrholek, would you mind adding this marker comments to the pages?

Benefits:

  • These would make it easier for people to know where to place specific content and styles, just like the <!-- Plugins and scripts required by this view--> comment, AND
  • Will make it easier for the upcoming build-aspnetcore feature to generate Razor views and make it easier for ASP.NET Core developers (like myself) to use this great template and keep their apps updated!

Was that a good enough sales pitch? ;-)

Just a couple of comments about two findings while doing this:

  1. In base-cards.html:743 there is a modal card that's not showcased in the page!

  2. I moved the modal dialogs in notification-modals.html:384 one line up, so they are kept within of what I identified as the "View content". I thought it would be better there because then they could take the specific view styles, if that were the case, and they would also be at the same level as the modal dialog in base-cards.html. BUT, of course, that's just my particular point of view, so just tell me if you prefer it to be the way it was.

TIA

@mvelosop
Copy link
Contributor Author

Hi @mrholek, any comments on this PR?

@HakanL
Copy link

HakanL commented May 10, 2018

I'm interested in seeing this added to the repo as well, any update?

@stale
Copy link

stale bot commented Jun 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants