Add marker comments in pages? #375
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mrholek, would you mind adding this marker comments to the pages?
Benefits:
<!-- Plugins and scripts required by this view-->
comment, ANDWas that a good enough sales pitch? ;-)
Just a couple of comments about two findings while doing this:
In base-cards.html:743 there is a modal card that's not showcased in the page!
I moved the modal dialogs in notification-modals.html:384 one line up, so they are kept within of what I identified as the "View content". I thought it would be better there because then they could take the specific view styles, if that were the case, and they would also be at the same level as the modal dialog in base-cards.html. BUT, of course, that's just my particular point of view, so just tell me if you prefer it to be the way it was.
TIA