Skip to content

Rename Header, Footer and Aside components #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
donalmurtagh opened this issue Jan 15, 2018 · 3 comments
Closed

Rename Header, Footer and Aside components #46

donalmurtagh opened this issue Jan 15, 2018 · 3 comments

Comments

@donalmurtagh
Copy link

donalmurtagh commented Jan 15, 2018 •
edited
Loading

Vue components should not have the same names as HTML elements, so Header and Footer and Aside should be renamed. When the app is built, these component names cause errors such as:

ERROR LOG: '[Vue warn]: Do not use built-in or reserved HTML elements as component id: header'
@xidedix
Copy link
Member

xidedix commented Jan 15, 2018

hi @donalmurtagh for the heads up!
We are aware of this issue already. A fix is around the corner.

@donalmurtagh
Copy link
Author

@xidedix is there already an open issue for this?

@xidedix
Copy link
Member

xidedix commented Jan 15, 2018

well, #46 actually :)

@donalmurtagh donalmurtagh changed the title Rename Header and Footer components Rename Header, Footer and Aside components Jan 15, 2018
woothu pushed a commit that referenced this issue Nov 23, 2018
@xidedix
Merge pull request #50 from mrholek/v1.0.9
d28a7b1 
v1.0.9 with Bootstrap 4.0.0
closes #46 
closes #45 
closes #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@donalmurtagh @xidedix