Skip to content

feat: additional 'scrollable' property for CModal.vue #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2021
Merged

feat: additional 'scrollable' property for CModal.vue #150

merged 1 commit into from
May 20, 2021

Conversation

barthy-koeln
Copy link

I was trying to add the class modal-dialog-scrollable to the appropriate modal element, which was not possible.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the develop branch (or to a previous version branch), not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
The commit removes two unnecessary whitespaces, that my IDE removed automatically. I can revert them if needed.

@barthy-koeln barthy-koeln changed the title feat: additional dialog classes property for CModal.vue feat: additional 'scrollable' property for CModal.vue May 19, 2021
@xidedix xidedix merged commit d781bed into coreui:dev May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants