ICS20v2: use Denom and Trace types
#1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
AdityaSripal,
colin-axner,
damiannolan and
sangier
as code owners
crodriguezvega
changed the base branch from
aditya/forwarding
to
carlos/rename-forwarding_info
crodriguezvega
changed the title
Denom and Trace typesDenom and Trace types
colin-axner
reviewed
Jun 19, 2024
colin-axner
reviewed
Jun 19, 2024
AdityaSripal
requested changes
Jun 19, 2024
| @@ -388,10 +413,9 @@ function onRecvPacket(packet: Packet) { | |||
|
|
|||
| if transferVersion == "ics20-1" { | |||
| FungibleTokenPacketData data = UnmarshalJSON(packet.data) | |||
| trace, denom = parseICS20V1Denom(data.denom) | |||
| denom = parseICS20V1Denom(data.denom) | |||
There was a problem hiding this comment.
THis is a bit confusing. Perhaps we can have better naming or a code comment on what each denom here represents
There was a problem hiding this comment.
I added a comment above to explain. Let me know if that's enough.
Base automatically changed from
carlos/rename-forwarding_info
to
aditya/forwarding
June 19, 2024 18:36
…-trace-typed-structures-to-ics20-v2-packet-definition
…-trace-typed-structures-to-ics20-v2-packet-definition # Conflicts: # spec/app/ics-020-fungible-token-transfer/README.md
AdityaSripal
requested changes
Jun 20, 2024
Co-authored-by: Aditya <[email protected]>
AdityaSripal
approved these changes
Jun 24, 2024
crodriguezvega
deleted the
carlos/1106-ics20-add-denom-and-trace-typed-structures-to-ics20-v2-packet-definition
branch
AdityaSripal
added a commit
that referenced
this pull request
Jun 24, 2024
* add recv logic and revert logic on error ack/timeout * multiple denoms but still support forwarding * lint * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <[email protected]> * address reviews * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <[email protected]> * small fixes * generate forwarding address if it doesn't exist * blank memo for now * only do revertInFlightChanges or refund packets on error ack, not both * make same changes for timeout * forwarding info struct, individual memos * fail early since forwarding must be atomic * address some small review comments * only set memo on last hop * address Stefano's and my review comments * missing bracket * destinationChannel -> destChannel * ICS20v2 path forwarding: simplify revert in-flight changes (#1110) * simplify revert in-flight changes * typo * nit: rename ForwardingInfo to Forwarding (#1112) * ICS20v2: use protobuf encoding for packet data of v2 (#1118) * ics20: use protobuf encoding for packet data of v2 * Update README.md * delete previously forwarded packet (#1119) * Update spec/app/ics-020-fungible-token-transfer/README.md Co-authored-by: Damian Nolan <[email protected]> * Apply suggestions from code review Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> * ICS20v2: use `Denom` and `Trace` types (#1115) * nit: rename ForwardingInfo to Forwarding * use Denom and Trace types * Apply suggestions from code review Co-authored-by: Aditya <[email protected]> * comments --------- Co-authored-by: Aditya <[email protected]> * review comment --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Cian Hatton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1106