Coverlet ThresholdType mulitple Value Note Working

[huangydyn]

Enviroment

• Mac Zsh
• coverlet.msbuild 3.0.3
• MsBuild

Issue

I want to set threhold for different thresholdtype

dotnet test /p:CollectCoverage=true /p:Threshold="10,10,8"  /p:ThresholdType="line,branch,method"

then return

MSBUILD : error MSB1006

[daveMueller]

Seems like a bug. Thanks for reporting, I'll take a look.

[daveMueller]

The feature for multiple thresholds isn't available in version 3.0.3 yet. It will be in the next release (#1123 (comment)).

Up to that point you can consume the nightly (https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md).

Also you have to take into a account that you can't pass property values containing a semicolon or comma to msbuild. One way to work around this is to escape the quotes (dotnet/msbuild#471), e.g.

dotnet test /p:CollectCoverage=true /p:Threshold=\"10,10,8\" /p:ThresholdType=\"line,branch,method\"

I will update the documentation for this.

[MarcoRossignoli]

closed in #1143

[Ogglas]

The feature for multiple thresholds isn't available in version 3.0.3 yet. It will be in the next release (#1123 (comment)).

Up to that point you can consume the nightly (https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md).

Also you have to take into a account that you can't pass property values containing a semicolon or comma to msbuild. One way to work around this is to escape the quotes (dotnet/msbuild#471), e.g.

dotnet test /p:CollectCoverage=true /p:Threshold=\"10,10,8\" /p:ThresholdType=\"line,branch,method\"

I will update the documentation for this.

This failed for me using Powershell.

MSBUILD : error MSB1006: Property is not valid.
Switch: 92

What worked for me though was using MSBuild escaping. Comma is %2c

Complete example:

dotnet test C:\Users\oscar\source\repos\project\Repository.sln --configuration Release /p:CollectCoverage=true /p:Include="[*]Repository.Web.Controllers.*" /p:Threshold="100%2c90%2c80" /p:ThresholdType="method%2cline%2cbranch"

dotnet/msbuild#2999 (comment)