Relocate tests using Tmds.ExecFunction to new test project coverlet.core.coverage.tests #1709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bertk
changed the title
Bertk
force-pushed
the
core-tests-fail-after-SDK-update
branch
3 times, most recently
from
3ab0dbe to
6bcb423
Compare
Bertk
changed the title
MarcoRossignoli
approved these changes
Jan 8, 2025
daveMueller
reviewed
Jan 8, 2025
daveMueller
approved these changes
Jan 9, 2025
Bertk
added a commit
to Bertk/coverlet
that referenced
this pull request
Jan 13, 2025
RetryHelper for specific exceptions
…tion) - Changed task in `publish-coverage-results.yml` from `PublishCodeCoverageResults@1` to `PublishCodeCoverageResults@2` and added `reportDirectory` parameter for coverage report location. - Added overloaded `BackupOriginalModule` methods in `InstrumentationHelper.cs` to improve backup flexibility, including a new `withBackupList` parameter. - Updated `InstrumentationHelperTests.cs` to align tests with the new method signature for backing up original modules.
Bertk
force-pushed
the
core-tests-fail-after-SDK-update
branch
from
d3ebb74 to
749f017
Compare
Bertk
added a commit
to Bertk/coverlet
that referenced
this pull request
Jan 16, 2025
Introduced a new test class `CoverageMergeTests` in the `Coverlet.Core.Tests` namespace. This class includes multiple unit tests for the `Merge` method of the `CoverageResult` class, validating the merging of modules, documents, classes, methods, lines, and branches to ensure data integrity and correct functionality.
…or for matching and non-matching documents.
daveMueller
reviewed
Jan 21, 2025
There was a problem hiding this comment.
I have one last question. Are you sure that test/coverlet.core.coverage.tests/out.txt, test/coverlet.core.coverage.tests/public.snk and test/coverlet.core.coverage.tests/key.publickey aren't needed anymore? Could you figure out for what they were used in the past?
This are some intermediat files which are not necessary. I use out.txt for test scripts and public.snk, key.publickey for new project with strong named assembly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following changes and enhancements:
Testing:
Build pipeline: