-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch content #593
Fetch content #593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR! I really like this approach for "trying out" the this new way of obtaining CPM. Once tested with a new release we can add this approach as an alternative to the readme. I think it still needs a run cmake-format run before merging though.
@TheLartians I run cmake-format. Seems it is passing now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Made a release |
It seems to work but :
|
I think we could update the publish script to also create a
Yeah as the output of |
For the sha256 I would do the contrary. Use some github action to write the SHA256 etc (all the one CMake can understand) inside the readme of the release. Modify the get_cpm to internally use this new method (it is more robust than file(download) cmake command). |
Hi,
This is a rework for #446. This PR is taking into account 3 scenari :
User use the get_cpm.cmake (no change for them)
Fetching with URL https://github.com/cpm-cmake/CPM.cmake/archive/refs/tags/v0.40.2.zip (use the .git_archival.txt)
Fetching with GIT_REPOSITORY (use git program to parse version)
As this PR doesn't modify the standard way to obtain CPM it allows to test it before switching to this method as the prefered one