Skip to content

Fix version filename for find_package redirects #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

patstew
Copy link
Contributor

@patstew patstew commented Jan 6, 2025

I think I made a mistake copying what FetchContent does in #604 which causes #629.

@patstew patstew force-pushed the find_package_redirects_version branch from 28e2998 to 2837d6d Compare January 20, 2025 10:14
@patstew
Copy link
Contributor Author

patstew commented Jan 20, 2025

I don't really understand how that build error in sol2 could possibly be related to this PR. Has clang been updated, or the relevant tags in the upstream repo changed?

@christopherbate
Copy link

Yes GitHub runner image ubuntu-latest was updated to 24.04 last month, after the last time that workflow ran successfully in this Repo. Probably need to set the runner to ubuntu-22.04 on the examples/clang job

higaski added a commit to ZIMO-Elektronik/CMakeModules that referenced this pull request Feb 25, 2025
higaski added a commit to ZIMO-Elektronik/CMakeModules that referenced this pull request Feb 25, 2025
Copy link
Member

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the issue! I'll try to find out what's up with sol2 and push changes here if needed.

@TheLartians TheLartians merged commit 33efd5f into cpm-cmake:master Mar 2, 2025
11 checks passed
@TheLartians
Copy link
Member

Fix released in v0.40.6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants