Skip to content

Refactor files #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Refactor files #38

merged 3 commits into from
Sep 19, 2024

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Sep 19, 2024

This is intended to allow calling both rust lib and python lib "cpp-linter" when installing with cargo or pip.

Also when using python, the entry point script is now the same as it is in v1.x: cpp_linter.main().

I also decided to split up the 1000 lines of code in src/rest_api/github_api.rs (into 3 files). This should make much easier to add support for other REST API clients.

@2bndy5 2bndy5 force-pushed the refactor-files branch 2 times, most recently from bd665b9 to 7c3b480 Compare September 19, 2024 06:11
This is intended to allow calling both rust lib and python lib "cpp-linter" when installing with cargo or pip.

Also when using python, the entry point script is now the same as it is in v1.x: `cpp_linter.main()`.
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 97.95022% with 14 lines in your changes missing coverage. Please review.

Project coverage is 98.50%. Comparing base (9189e86) to head (7da7084).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cpp-linter/src/rest_api/github/mod.rs 97.74% 7 Missing ⚠️
cpp-linter/src/rest_api/github/specific_api.rs 98.02% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files          12       14    +2     
  Lines        3144     3144           
=======================================
  Hits         3097     3097           
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2bndy5 2bndy5 merged commit 244c672 into main Sep 19, 2024
37 checks passed
@2bndy5 2bndy5 deleted the refactor-files branch September 19, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant