Skip to content

[docs] Make Hunter and CMake versions consistent #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

[docs] Make Hunter and CMake versions consistent #378

merged 1 commit into from
Apr 12, 2021

Conversation

SamuelMarks
Copy link

No description provided.

@SamuelMarks SamuelMarks mentioned this pull request Apr 9, 2021
Open
@NeroBurner
Copy link

Awesome, good job

Did you make all those changes by hand?

@SamuelMarks
Copy link
Author

@NeroBurner Partially. Used rg to find the issues, sometimes fastmod to apply fixes, and other times by hand. Now that it's all internally consistent it should be trivially to update in every place on release using pure sed (or fastmod… which I prefer for recursive application and that it has a -F argument… also it's cross-platform).

@NeroBurner
Copy link

thanks for the explanation! And once again great job

rbsheth
rbsheth approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@rbsheth rbsheth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rbsheth rbsheth merged commit dc0d79c into cpp-pm:master Apr 12, 2021
@rbsheth
Copy link
Member

rbsheth commented Apr 16, 2021

Released: https://github.com/cpp-pm/hunter/releases/tag/v0.23.298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbsheth rbsheth rbsheth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuelMarks @NeroBurner @rbsheth