Skip to content

Updating Focus Visible #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 1, 2022
Merged

Updating Focus Visible #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
01e24c7
Updating Focus Visible
Antonio-Laguna Jun 30, 2022
f3b821e
Returning CHANGELOG
Antonio-Laguna Jun 30, 2022
a1afc34
Updating tests
Antonio-Laguna Jun 30, 2022
7aca779
focus-visible : code review (#514)
romainmenke Jul 1, 2022
5297739
Updating CHANGELOG
Antonio-Laguna Jul 1, 2022
7b074a0
focus-visible : code review (#514)
romainmenke Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.autoprefixer.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,7 @@
word-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.autoprefixer.false.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,7 @@
word-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.ch38.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,7 @@
overflow-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.ch88-ff78-saf10.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,7 @@ h1.test-custom-selectors,h2.test-custom-selectors,h3.test-custom-selectors,h4.te
overflow-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.ch88-ff78.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,7 @@ h1.test-custom-selectors,h2.test-custom-selectors,h3.test-custom-selectors,h4.te
overflow-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.ch88-ff78.no-is-pseudo.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,7 @@ h1.test-custom-selectors,h2.test-custom-selectors,h3.test-custom-selectors,h4.te
overflow-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,7 @@
word-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.ff49.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,7 @@
overflow-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.ff66.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,7 @@
overflow-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
7 changes: 1 addition & 6 deletions plugin-packs/postcss-preset-env/test/basic.ie10.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,12 +278,7 @@
word-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
-ms-flex-order: 26;
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
-ms-flex-order: 26;
order: 26;
}
Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.nesting.false.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,11 +269,7 @@ h1.test-custom-selectors,h2.test-custom-selectors,h3.test-custom-selectors,h4.te
word-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.op_mini.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,7 @@ h1.test-custom-selectors,h2.test-custom-selectors,h3.test-custom-selectors,h4.te
word-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
2 changes: 1 addition & 1 deletion plugin-packs/postcss-preset-env/test/basic.preserve.true.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ h1.test-custom-selectors,h2.test-custom-selectors,h3.test-custom-selectors,h4.te
word-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
-webkit-box-ordinal-group: 27;
-webkit-order: 26;
-moz-box-ordinal-group: 27;
Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.safari15.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,7 @@
overflow-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.stage0-ff49.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,7 @@ h1.test-custom-selectors,h2.test-custom-selectors,h3.test-custom-selectors,h4.te
overflow-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.stage0-ff66.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,7 @@ h1.test-custom-selectors,h2.test-custom-selectors,h3.test-custom-selectors,h4.te
overflow-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
6 changes: 1 addition & 5 deletions plugin-packs/postcss-preset-env/test/basic.stage0.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,11 +276,7 @@ h1.test-custom-selectors,h2.test-custom-selectors,h3.test-custom-selectors,h4.te
word-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible, .js-focus-visible .test-focus-visible-pseudo-class.focus-visible {
order: 26;
}

Expand Down
2 changes: 1 addition & 1 deletion plugin-packs/postcss-preset-env/test/client-side-polyfills.stage-1.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
order: 1;
}

.focus-visible {
.focus-visible.js-focus-visible, .js-focus-visible .focus-visible {
order: 2;
}

Expand Down
2 changes: 1 addition & 1 deletion plugin-packs/postcss-preset-env/test/client-side-polyfills.stage-2.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
order: 1;
}

.focus-visible {
.focus-visible.js-focus-visible, .js-focus-visible .focus-visible {
order: 2;
}

Expand Down
10 changes: 1 addition & 9 deletions plugin-packs/postcss-preset-env/test/layers-basic.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,15 +445,7 @@ h1.test-custom-selectors:not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):n
word-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible:not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#) {
-webkit-box-ordinal-group: 27;
-webkit-order: 26;
-moz-box-ordinal-group: 27;
-ms-flex-order: 26;
order: 26;
}

.test-focus-visible-pseudo-class:focus-visible:not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#) {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible:not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#), .js-focus-visible:not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#) .test-focus-visible-pseudo-class.focus-visible {
-webkit-box-ordinal-group: 27;
-webkit-order: 26;
-moz-box-ordinal-group: 27;
Expand Down
2 changes: 1 addition & 1 deletion plugin-packs/postcss-preset-env/test/layers-basic.preserve.true.expect.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ h1.test-custom-selectors:not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):n
word-wrap: break-word;
}

.test-focus-visible-pseudo-class.focus-visible:not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#) {
.test-focus-visible-pseudo-class.focus-visible.js-focus-visible:not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#), .js-focus-visible:not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#):not(#\#) .test-focus-visible-pseudo-class.focus-visible {
-webkit-box-ordinal-group: 27;
-webkit-order: 26;
-moz-box-ordinal-group: 27;
Expand Down
2 changes: 1 addition & 1 deletion plugins/css-blank-pseudo/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { PluginCreator } from 'postcss';
import parser from 'postcss-selector-parser';
import isValidReplacement from './is-valid-replacement.mjs';

type pluginOptions = { color?: string, preserve?: boolean };
type pluginOptions = { preserve?: boolean, replaceWith?: string };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised this was a leftover which would have exported the wrong types, this hasn't been published yet so it's not a big concern


const creator: PluginCreator<pluginOptions> = (opts?: pluginOptions) => {
const options = Object.assign(
Expand Down
8 changes: 1 addition & 7 deletions plugins/postcss-focus-visible/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
node_modules
dist
package-lock.json
yarn.lock
*.log*
*.result.css
*.result.css.map
!.editorconfig
!.gitignore
!.rollup.js
!.tape.js
!.travis.yml
dist/*
20 changes: 19 additions & 1 deletion plugins/postcss-focus-visible/.tape.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ postcssTape(plugin)({
'basic:replacewith': {
message: 'supports { replaceWith: "[focus-visible]" } usage',
options: {
replaceWith: '[focus-visible]'
replaceWith: '[data-focus-visible-added]'
}
},
'basic:preserve': {
Expand All @@ -24,4 +24,22 @@ postcssTape(plugin)({
preserve: false
}
},
'browser': {
message: 'css for browser tests',
},
'examples/example': {
message: 'minimal example',
},
'examples/example:preserve-false': {
message: 'minimal example',
options: {
preserve: false
}
},
'examples/example:replacewith': {
message: 'minimal example',
options: {
replaceWith: '[focus-visible]'
}
},
});
5 changes: 5 additions & 0 deletions plugins/postcss-focus-visible/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changes to PostCSS Focus Visible

### Unreleased (major)

- Breaking: Changed generated classes so it prepends `.js-focus-visible` to the
generated class so CSS is applied when the polyfill is known to be running.

### 6.0.4 (February 5, 2022)

- Improved `es module` and `commonjs` compatibility
Expand Down
Loading