Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
final typescript conversions #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
final typescript conversions #712
Changes from all commits
864041d
6a873b5
fe3b39d
5621822
30c9136
a0af2b0
91bb5a5
4490865
444ac2e
d9fe521
f1c9e15
73d79a2
b362b71
262fa57
52dbbf3
5d6718b
bdeb1fe
a555d63
41365af
4ab9e3b
eb03cc7
0f4abed
0c8b51c
9f2e625
fcf715a
37d60a7
ed56b63
a47c6af
8c61ae1
2b56a1f
c7eb900
d2d24cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going over all the options of the 3rd party plugins I found 2 that have the
preserve
feature but use a different name for the option.We now map these based on user preference for
preserve
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add this to the CHANGELOG since this is actually a fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)