Add root_dir capability for multiple roots #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsegal
changed the title
| @@ -76,6 +76,10 @@ def self.setup_options(options = {}) | |||
| options[:model_dir] = ['app/models'] | |||
| end | |||
|
|
|||
| if(options[:root_dir].empty?) | |||
| options[:root_dir] = ['/'] | |||
There was a problem hiding this comment.
Is this supposed to be Rails.root? A slash doesn't seem to a correct default value from the caller/user perspective.
There was a problem hiding this comment.
- Thats true, we could just make the default
'' - The place where root_dir is used in will be unchanged:
File.join(root_directory, UNIT_TEST_DIR, "%MODEL_NAME%_test.rb")
There was a problem hiding this comment.
Could you make the change so I can accept the PR?
|
@ctran I just finished the update. (i'll clean up the other PRs after the merge) One note, I did some minor refactoring:
|
|
Awesome. Thanks. |
ctran
added a commit
that referenced
this pull request
Dec 1, 2015
Add root_dir capability for multiple roots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations for models in subdirectories of engines/subtrees/etc #291
I believe this is similar to the following issues: #190, #131, #88
To get it to work on my project, I have the following 2 lines in auto_annotate_models.rake: