Refactor RSpec for AnnotateModels (5) - structuralize test cases #741
Conversation
| let :header do | ||
| 'Schema Info' | ||
| context 'when option is not present' do | ||
| subject do |
There was a problem hiding this comment.
Any reason why is subject under context instead of describe?
There was a problem hiding this comment.
@drwl Thanks, I'd like to split large commits into smaller ones.
I use context and describe depending on following link.
https://lmws.net/describe-vs-context-in-rspec
Are you getting at that subject under context is strange and subject should be under describe?
There was a problem hiding this comment.
Yep, I've usually seen subject be under describe instead of context but there doesn't seem to be anything on the style guide against it.
https://github.com/rubocop-hq/rspec-style-guide#subject-naming-in-context
Has subject under multiple contexts so seems to be fine.
There was a problem hiding this comment.
@drwl All right. I'll use your reply as a reference in the next PR. Thank you.
The test cases of AnnotateModels.get_schema_info was separated into two sections. So I merged them into one, and refactor test cases. This PR is new version of #741.
The test cases of AnnotateModels.get_schema_info was separated into two sections. So I merged them into one, and refactor test cases. This PR is new version of ctran#741.
The test cases of
AnnotateModels.get_schema_infowas separated into two clauses.So I merged them into one clause, and refactor test cases.