Update to rubocop 1.12.x for newer ruby support #931
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravitystorm
force-pushed
the
rubocop_1_12
branch
from
d44531c to
9379336
Compare
|
Thanks! This was updated in HEAD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #927 the CI builds for 2.7 and 3.0 failed, because rubocop 0.68.x is too old to recognise them.
This PR updates rubocop to 1.12.x, which is the last version that supports ruby 2.4. That version of rubocop also supports 2.7 and 3.0, so this PR will enable #927 to work (after rebasing).
The bulk of the diff in this PR is just running
rubocop --auto-gen-configafter the rubocop update.