Skip to content

Add ParameterInfo #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2022
Merged

Add ParameterInfo #124

merged 5 commits into from
May 24, 2022

Conversation

aslakhellesoy
Copy link
Contributor

🤔 What's changed?

I have modified the TypeScript implementation to add the following:

  • GeneratedExpression#parameterInfos => ParameterInfo[]
  • Made ParameterType#type public and improved the typings
  • Fixed the type on a couple of built-in parameter types

⚡️ What's your motivation?

My motivation is to implement a "quick fix" for undefined steps in the language server - see https://github.com/cucumber/language-server/pull/45/files

It uses the new ParameterInfo object to generate step definitions for multiple languages (using a Mustache template).
In order to do this for statically typed languages, we need to know the type of each parameter.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@aslakhellesoy aslakhellesoy merged commit 80b573f into main May 24, 2022
@aslakhellesoy aslakhellesoy deleted the add-parameter-info branch May 24, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants