Skip to content

Ruby: Changes prep for v17 #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-rubygem.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.0.2'
ruby-version: '3.2'
bundler-cache: true
- uses: cucumber/[email protected]
with:
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/test-ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,20 @@ jobs:
matrix:
os:
- ubuntu-latest
ruby: ['2.7', '3.0']
ruby: ['2.7', '3.0', '3.1', '3.2']
include:
- os: windows-latest
ruby: '3.0'
ruby: '3.2'
- os: macos-latest
ruby: '3.0'
ruby: '3.2'

steps:
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
working-directory: ruby
- name: bundle exec rspec
- name: rspec
working-directory: ruby
run: bundle exec rspec
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Changed
- [Ruby] Minimum supported ruby is now 2.5+

- [JavaScript] Added TypeScript source to the package ([#211](https://github.com/cucumber/cucumber-expressions/pull/211))

Expand Down
3 changes: 0 additions & 3 deletions ruby/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,5 @@ coverage/
acceptance/
pkg/
*.gem
.compared
.deps
.tested*
*-go
*.iml
1 change: 0 additions & 1 deletion ruby/.rspec

This file was deleted.

27 changes: 27 additions & 0 deletions ruby/.rubocop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
inherit_from: .rubocop_todo.yml

inherit_mode:
merge:
- Exclude

AllCops:
TargetRubyVersion: 2.5
NewCops: enable

# Disabled on our repo's to enable polyglot-release
Gemspec/RequireMFA:
Enabled: false

Layout/LineLength:
Max: 200

Style/Documentation:
Enabled: false

Style/RegexpLiteral:
EnforcedStyle: slashes
AllowInnerSlashes: true

# Once we enable rubocop-rspec
#RSpec/MessageSpies:
# EnforcedStyle: receive
Loading