Fix missing Python parameter type defaults #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
The project documentation outlines for Customer Parameter Types that
use_for_snippets
"Defaults totrue
" and thatprefer_for_regexp_match
"Defaults tofalse
".Although this aligns with the documented Python example, its implementation is missing default values for those keyword arguments:
With this PR:
ParameterType
class.typing.List
andlist
(through__future__.annotations
).⚡️ What's your motivation?
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Whether small correction to alternatives in README.md is appropriate.
📋 Checklist: