Config file Option update #1434
Conversation
src/cli/profile_loader.ts
Outdated
| } else { | ||
| configFilePath = path.join(this.directory, 'cucumber.js') | ||
| } | ||
| const definitionsFilePath = configFilePath |
There was a problem hiding this comment.
Let's remove this reassignment.
There was a problem hiding this comment.
i am noty able to push new branch .. i had 2 changes somehow i tried to edit the file and createpr .. but its nont allowing me to combine all changes into patch can you suggest
There was a problem hiding this comment.
and where do i update the documentation ? also @aslakhellesoy ..i need 2 patches to go together ..
Patch 2 and 3 i guess under my name .. one for arg parser update one to provide the args and pass the file path
Pls check if both are good
There was a problem hiding this comment.
You could start over from master:
git checkout -b config-option
# hack hack
git commit -m "bla bla"
# hack hack
git commit -m "bla bla"
# hack hack
git commit -m "bla bla"
git push
# Open the URL in your terminal and create a pull request
# hack hack
git commit -m "bla bla"
git push
# Now you just pushed a new commit to the branch of your pull request.
More details here: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request
There was a problem hiding this comment.
Remote: Permission to cucumber/cucumber-js.git denied to deepziem. unable to access 'https://github.com/cucumber/cucumber-js.git/': The requested URL returned error: 403
There was a problem hiding this comment.
Maybe take some time to learn how to use git and GitHub wold help?
There was a problem hiding this comment.
Hang on - are you editing files in the browser using the GitHub editor?
There was a problem hiding this comment.
yes @aslakhellesoy .. i am .. i am not able to branch or push from desktop .. not sure why, however i pull and test locally and update here .. and pull again and test.. is it ok you can help update or approve
There was a problem hiding this comment.
hi @aslakhellesoy .. can you approve the changes pls? is there any issue still..
Also .. is there a way we can make Deasync work in cucumber js ? .. cucumberjs and selenium commands deasync is not working in higher versions of cucumber .. post 5.03 versions. Till then it worked.. i really need something there pls.
|
@deepziem are you confident into continue working on this PR? |
|
Completed in #1794 |
Provide a default relative cucumber.js file for config option
--config filePath or -c filePath