fix: add IMethods interface for use in time module functions #2111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR does the following,
IMethods
intime.ts
extending fromGlobalTimers
beginTiming
andendTiming
insrc/time.ts
void
forbeginTiming
number
forendTiming
methods
object to make use ofIMethods
interfacetimeoutId
to useTimerId
instead ofNodeJS.Timeout
⚡️ What's your motivation?
The motivation for this update/change is the incremental completion of #1648 in small manageable PRs.
I imagine this will be one of multiple PRs to replace explicit
any
with a type.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
any
and defining an interface forstrictly typing
, is this the recommended approach for this project?📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.