Skip to content

fix: update mocha config to avoid test timeouts #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2023
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Feb 11, 2023

🤔 What's changed?

Increase mocha timeout from 2s to 5s. We don't routinely have tests timeout so this should not make the build any slower in general.

⚡️ What's your motivation?

Fixes #2234. One or two API tests are doing multiple test runs and that's taking them over the 2s timeout on Windows sometimes. I expect we'll do more of this kind of test (i.e. using the runCucumber API) so don't want to just do it on a test by test basis.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

Coverage Status

Coverage: 98.564%. Remained the same when pulling 76e16ae on fix/flaky-api-tests into 847f613 on main.

@davidjgoss davidjgoss merged commit 6f3385c into main Feb 11, 2023
@davidjgoss davidjgoss deleted the fix/flaky-api-tests branch February 11, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test in javascript api
2 participants