Fix readme on using scenario.attach #517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run as --dry-run
Conflicts: lib/cucumber/runtime.js
fix the failing spec after enabling dry run option
Mark scenario as skipped in dryrun mode similar to cucumber ruby standards
Conflicts: lib/cucumber/listener/summary_formatter.js
| @@ -400,8 +399,9 @@ when a scenario fails: | |||
| ``` javascript | |||
| this.After(function (scenario, callback) { | |||
| if (scenario.isFailed()) { | |||
| webDriver.takeScreenshot().then(stream) { | |||
| scenario.attach(stream, 'image/png', callback); | |||
| driver.takeScreenshot().then(function (stream) { | |||
There was a problem hiding this comment.
On the latest version of selenium webdriver, takeSceenshot returns a string that is a base-64 encoded PNG. Thus stream should be renamed to str. I think it will be simpler if the json formatter stops encoding with base64 and leaves it up to the user to encode it.
|
Closing as with 5fb6706 there is no intermediate conversion to string and we just encode it as base64 when adding it to the json output. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #275