-
Notifications
You must be signed in to change notification settings - Fork 10
Update to latest groovy and cucumber jvm #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest groovy and cucumber jvm #47
Conversation
…entered (\d+) into .* calculator$/" is no longer required, as Gherkin will not compile duplicated steps like this
…ucumber-expressions` to always pick it up as a regexp as intended. See: cucumber/cucumber-expressions@2ab6bad#diff-2362714f85d9eebc65d6f232fc807e5e9706973832e7f70a33a190e7108dbb2cR49
…nd @ParameterType instead. See: cucumber/cucumber-jvm#1797
…engine` remove duplicate versions that are already in root pom
…s-maven-surefire-plugin-3.x' into update-to-latest-groovy-and-cucumber-jvm
* Use -bom projects to manage dependencies where possible * Replace JUnit 4 with JUnit 5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya, looked pretty good. I pushed some changes to help out.
Specifically:
- Upgrading to Surefire v3 so we can use JUnit 5.
- Using Bills of Material to keep all the dependencies aligned (and remove all the explicit version numbers everywhere)
- Replacing JUnit 4 with JUnit 5.
Don't forget to add an entry to the CHANGELOG.md
.
I don't know the historry to running the maven ant groovy-cli-test, I replaced it with the `org.junit.platform.console.ConsoleLauncher
Interesting question.
I get the impression that the groovy-cli-test
is testing the cucumber-groovy-shaded.jar
that is produced when building this project. It seems to be a way to run Cucumber Groovy in a standalone fashion.
If you think that currently there is no reason to provide a shaded jar, please do feel free to remove the code that creates the shaded jar along with the test for it. Since this project currently doesn't have a maintainer (#27) and I don't use Groovy on regular basis I'll defer to your judgement on this.
…longer supported, because it defaults to strict-mode. (See: cucumber/cucumber-jvm@5fbae84)
I put the |
…junit console launcher anymore
Hi @lsiu, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Cheers! @lsiu since you are one of the few people using |
@mpkorstanje , I will do what I can. |
Mmh. Cucumber-Java 8 hasn't been deprecated yet. And I'm planning to have a replacement ready when that happens. If you want you could help out with the replacement instead. But I'll leave that up to your interests: |
🤔 What's changed?
Upgrade to the latest
groovy
version 4.0.11 andcucumber-core
version 7.11.2⚡️ What's your motivation?
I would like to use cucumber-groovy-jvm with the latest cucumber-core
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
groovy-cli-test
, I replaced it with the `org.junit.platform.console.ConsoleLauncher📋 Checklist: