This repository was archived by the owner on Jun 2, 2023. It is now read-only.
Add Cucumber-JVM migration module #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
added a commit
to openrewrite/rewrite-testing-frameworks
that referenced
this pull request
Mar 12, 2023
2 tasks
mpkorstanje
reviewed
Mar 12, 2023
| - uses: actions/checkout@v3 | ||
| - uses: cucumber/[email protected] | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Note to self: Add this to the secrets.
mpkorstanje
reviewed
Mar 16, 2023
|
@timtebeek I won't get around to attending these changes today. If you happen to have time in the 14 days do feel free. |
|
Thanks for reviewing; applied your suggestions just now. Had the version set for |
|
Yup |
timtebeek
added a commit
to openrewrite/rewrite-testing-frameworks
that referenced
this pull request
Mar 21, 2023
mpkorstanje
approved these changes
Mar 23, 2023
mpkorstanje
changed the title
|
Thanks for the merge! Once it's released I'll pick it up on our end to make it available in the platform, and see if there's any projects I can use to try it out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation based on export of rewrite-testing-framwork cucumber recipes with permission as both the original author there, and an employee of @moderneinc .
This project aims to help users of cucumber-jvm migrate to newer versions by changing their code to adopt breaking changes.