Skip to content

Deprecate and remove Needle & Weld #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
mpkorstanje opened this issue Aug 31, 2019 · 3 comments
Closed
2 tasks done

Deprecate and remove Needle & Weld #1763

mpkorstanje opened this issue Aug 31, 2019 · 3 comments
Labels
🏦 debt Tech debt 💔 breaking change This will require a major release 🥒 core team Candidate for going onto the Cucumber Open Board: https://github.com/orgs/cucumber/projects/8 ✅ accepted The core team has agreed that it is a good idea to fix this
Milestone

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Aug 31, 2019

Summary

Cucumber supports a number of Java EE containers:

  • CDI2
  • DeltaSpike
  • Needle
  • OpenEJB
  • Weld

While they are relatively low maintenance as modules go it would be good to remove some of the duplicate functionality.

  • Delta Spike currently supports OpenEJB and Weld and can replace both object factory implementations.
  • Needle is closely tied JBoss and can be replaced with DeltaSpike/CDI2 object factory implementations.

@toepi, @rmannibucau, @lbilger, @jangalinski, @FSeidinger, @aaronwalker since you have all contributed to these modules in the past and present:

  1. Are the above statements correct?
  2. Do you have any strong objections against deprecating these modules?
  3. Any thing else?

Todo

  • v6.x.x Deprecate
  • v7.0.0 Remove
@mpkorstanje mpkorstanje added this to the 6.0.0 milestone Aug 31, 2019
@rmannibucau
Copy link
Contributor

Hi @mpkorstanje ,

Weld, potentially OpenWebBeans which was not contributed, and CDI2 clearly overlap and I guess only CDI2 should stay since others don't bring anything anymore.
For CDI1, DeltaSpike makes sense IMHO.
OpenEJB does not have a replacement yet - I guess it should converge to EJBContainer instead of internals - which would then support all EE containers with some CDI mix (EJBContainer includes CDI but not the opposite but you can't use EJBContainer to test a pure CDI/Microprofile app since it would add behavior which can make fail your boot or break classpath). Based on EJBContainer I guess all EE containers are supported so I'd say CDI2 and EJBContainer are required, DeltaSpike for a few years for CDI < 2 and we are good.

Does it makes sense even if EJBContainer still needs to be developped?

@jangalinski
Copy link
Contributor

Though the above (needle closely tied to jboss) is not completely true, I am fine with deprecating needle support, haven't used it myself for years.

@aaronwalker
Copy link
Contributor

Happy for Weld support to be deprecated.

@mpkorstanje mpkorstanje modified the milestones: 6.0.0, 5.x.x Sep 8, 2019
@mpkorstanje mpkorstanje changed the title Consider deprecating Neelde, OpenEJB & Weld Deprecate Neelde, OpenEJB & Weld Sep 8, 2019
@mpkorstanje mpkorstanje mentioned this issue Sep 8, 2019
6 tasks
@aslakhellesoy aslakhellesoy changed the title Deprecate Neelde, OpenEJB & Weld Deprecate Needle, OpenEJB & Weld Jan 10, 2020
@mpkorstanje mpkorstanje modified the milestones: 5.x.x, v6.x.x Apr 17, 2020
@mpkorstanje mpkorstanje changed the title Deprecate Needle, OpenEJB & Weld Deprecate and Remove Needle, OpenEJB & Weld Jul 17, 2020
@mpkorstanje mpkorstanje changed the title Deprecate and Remove Needle, OpenEJB & Weld Deprecate and remove Needle, OpenEJB & Weld Jul 17, 2020
@mpkorstanje mpkorstanje changed the title Deprecate and remove Needle, OpenEJB & Weld Deprecate and remove Needle & Weld Jul 17, 2020
@mpkorstanje mpkorstanje modified the milestones: v6.x.x, 7.0.0 Jul 17, 2020
@aslakhellesoy aslakhellesoy added 🏦 debt Tech debt 💔 breaking change This will require a major release ✅ accepted The core team has agreed that it is a good idea to fix this labels Feb 2, 2021
@aurelien-reeves aurelien-reeves added the 🥒 core team Candidate for going onto the Cucumber Open Board: https://github.com/orgs/cucumber/projects/8 label Feb 16, 2021
mpkorstanje added a commit that referenced this issue Apr 3, 2021
Consider using `cucumber-jakarta-cdi` or `cucumber-cdi2`.

Fixes: #1763
mpkorstanje added a commit that referenced this issue Apr 3, 2021
Consider using `cucumber-jakarta-cdi` or `cucumber-cdi2`.

Fixes: #1763
mpkorstanje added a commit that referenced this issue Apr 3, 2021
Consider using `cucumber-jakarta-cdi` or `cucumber-cdi2`.

Fixes: #1763
@mattwynne mattwynne moved this to Implemented in Cucumber Open Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt 💔 breaking change This will require a major release 🥒 core team Candidate for going onto the Cucumber Open Board: https://github.com/orgs/cucumber/projects/8 ✅ accepted The core team has agreed that it is a good idea to fix this
Projects
Status: Implemented
Development

No branches or pull requests

6 participants