Skip to content

Deprecate multiple --tag arguments #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
mpkorstanje opened this issue Apr 18, 2020 · 1 comment
Closed
2 tasks done

Deprecate multiple --tag arguments #1948

mpkorstanje opened this issue Apr 18, 2020 · 1 comment
Milestone
6.0.0

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Apr 18, 2020 •
edited
Loading

Currently it is possible to use --tag "@example1" --tag "@example2" or @CucumberOptions(tags={"@example1", "@example2"}). This is confusing. Are these combined using and semantics or with or semantics? (Hint: It depends on the version of Cucumber).

Instead this should be replaced with a single tag expression @example1 and/or @example2.

TODO:

  • v5.x.x: Print a warning when multiple tag expressions are used
  • v6.0.0: Remove multiple tag expressions
@mpkorstanje mpkorstanje added the ⚡ enhancement Request for new functionality label Apr 18, 2020
@mpkorstanje mpkorstanje added this to the 5.x.x milestone Apr 18, 2020
@mpkorstanje mpkorstanje removed the ⚡ enhancement Request for new functionality label Apr 18, 2020
@mpkorstanje mpkorstanje changed the title Deprecate multiple --tag parameters Deprecate multiple --tag arguments Apr 18, 2020
mpkorstanje added a commit that referenced this issue Apr 23, 2020
@mpkorstanje
[Core] Deprecate multiple tag arguments in @CucumberOptions
6b37bd3 
Passing multiple tags through `@CucumberOptions` has confusing
semantics. Using a single tag expressions clears up any confusion and
harmonizes ``@CucumberOptions` with `cucumber.filter.tags`.

For example:
```java
@CucumberOptions(tags="(@cucumber or @Pickle) and not @salad")
```
```properties
cucumber.filter.tags="(@cucumber or @Pickle) and not @salad"
```
Closes: #1948
@mpkorstanje mpkorstanje mentioned this issue Apr 23, 2020
Merged
3 tasks
mpkorstanje added a commit that referenced this issue Apr 23, 2020
@mpkorstanje
[Core] Deprecate multiple tag arguments in @CucumberOptions
326a40e 
Passing multiple tags through `@CucumberOptions` has confusing
semantics. Using a single tag expressions clears up any confusion and
harmonizes ``@CucumberOptions` with `cucumber.filter.tags`.

For example:
```java
@CucumberOptions(tags="(@cucumber or @Pickle) and not @salad")
```
```properties
cucumber.filter.tags="(@cucumber or @Pickle) and not @salad"
```
Partial fix for: #1948
@mpkorstanje mpkorstanje modified the milestones: 5.x.x, 6.0.0 Apr 23, 2020
mpkorstanje added a commit that referenced this issue Apr 23, 2020
@mpkorstanje
[Core] Remove multiple tag arguments from @CucumberOptions
5b73489 
Passing multiple tags through `@CucumberOptions` has confusing
semantics. Using a single tag expressions clears up any confusion and
harmonizes ``@CucumberOptions` with `cucumber.filter.tags`.

For example:
```java
@CucumberOptions(tags="(@cucumber or @Pickle) and not @salad")
```
```properties
cucumber.filter.tags="(@cucumber or @Pickle) and not @salad"
```

Closes: #1948
@mpkorstanje
Copy link
Contributor Author

Closed by: 5b73489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@mpkorstanje