Skip to content

[Core] Include all fields in JsonFormatters failure feature #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

mpkorstanje
Copy link
Contributor

Consumers of the json output expect all fields to be present. To avoid
breaking consumers we include all fields in the dummy feature that is
generated when cucumber fails to execute.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Consumers of the json output expect all fields to be present. To avoid
breaking consumers we include all fields in the dummy feature that is
generated when cucumber fails to execute.
@mpkorstanje mpkorstanje force-pushed the core-include-all-fields-in-json-failure-feature branch from 29b3df1 to a98e7b2 Compare April 23, 2020 12:27
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 86.639% when pulling a98e7b2 on core-include-all-fields-in-json-failure-feature into fa2d198 on v6.x.x.

@mpkorstanje mpkorstanje merged commit fcc9ab6 into v6.x.x Apr 23, 2020
@mpkorstanje mpkorstanje deleted the core-include-all-fields-in-json-failure-feature branch April 23, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants