Skip to content

[Core] Deprecate multiple tag arguments in @CucumberOptions #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Apr 23, 2020

Passing multiple tags through @CucumberOptions has confusing
semantics. Using a single tag expressions clears up any confusion and
harmonizes @CucumberOptions with cucumber.filter.tags.

For example:

@CucumberOptions(tags="(@cucumber or @pickle) and not @salad")
cucumber.filter.tags="(@cucumber or @pickle) and not @salad"

Partial fix for: #1948

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Passing multiple tags through `@CucumberOptions` has confusing
semantics. Using a single tag expressions clears up any confusion and
harmonizes ``@CucumberOptions` with `cucumber.filter.tags`.

For example:
```java
@CucumberOptions(tags="(@cucumber or @Pickle) and not @salad")
```
```properties
cucumber.filter.tags="(@cucumber or @Pickle) and not @salad"
```
Partial fix for: #1948
@mpkorstanje mpkorstanje force-pushed the core-deprecate-multiple-tags-in-cucumber-options branch from 6b37bd3 to 326a40e Compare April 23, 2020 13:10
@mpkorstanje mpkorstanje merged commit 326a40e into master Apr 23, 2020
@mpkorstanje mpkorstanje deleted the core-deprecate-multiple-tags-in-cucumber-options branch April 23, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant