[Spring] Support multithreaded execution of scenarios #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
ishmeister-master
branch
3 times, most recently
from
78622b6 to
9f9de5f
Compare
When running in parallel the dependency injection context was shared between scenarios. This made it impossible to run cucumber test with spring without forking the JVM. To reduce the resources required to execute a test each thread now will have its own dependency injection context allowing tests to be executed in parallel threads. Related issues: - #1106 This fixes #1106
mpkorstanje
force-pushed
the
ishmeister-master
branch
from
9f9de5f to
372619e
Compare
mpkorstanje
added a commit
that referenced
this pull request
Jun 18, 2017
The TestContextManager(Class<?>) uses a static ContextCache. This meant that all step definitions from all tests would be registered in same context, possibly multiple times. This is resolved by creating a ContextCache for each SpringFactory. Related issues: - https://travis-ci.org/cucumber/cucumber-jvm/jobs/244215644 - #1148
mpkorstanje
added a commit
that referenced
this pull request
Jun 18, 2017
The TestContextManager(Class<?>) uses a static ContextCache. This meant that all step definitions from all tests would be registered in same context, possibly multiple times when running in parallel. This is resolved by creating a ThreadLocal ContextCache for each SpringFactory. Related issues: - https://travis-ci.org/cucumber/cucumber-jvm/jobs/244215644 - #1148
mpkorstanje
added a commit
that referenced
this pull request
Jun 18, 2017
The TestContextManager(Class<?>) uses a static ContextCache. This meant that step definitions from different threads could be registered in same context multiple times when running in parallel. This is resolved by creating a ThreadLocal ContextCache for each SpringFactory. Related issues: - https://travis-ci.org/cucumber/cucumber-jvm/jobs/244215644 - #1148
mpkorstanje
added a commit
that referenced
this pull request
Jun 18, 2017
The TestContextManager(Class<?>) uses a static ContextCache. This meant that step definitions from different threads could be registered in same context multiple times when running in parallel. This is resolved by creating a ThreadLocal ContextCache for each SpringFactory. Related issues: - https://travis-ci.org/cucumber/cucumber-jvm/jobs/244215644 - #1148
mpkorstanje
added a commit
that referenced
this pull request
Jun 18, 2017
The TestContextManager(Class<?>) uses a static ContextCache. This meant that step definitions from different threads could be registered in same context multiple times when running in parallel. This is resolved by creating a ThreadLocal ContextCache for each SpringFactory. Related issues: - https://travis-ci.org/cucumber/cucumber-jvm/jobs/244215644 - #1148
mpkorstanje
added a commit
that referenced
this pull request
Jun 18, 2017
The TestContextManager(Class<?>) uses a static ContextCache. This meant that step definitions from different threads could be registered in same context multiple times when running in parallel. This is resolved by creating a ThreadLocal ContextCache for each SpringFactory. Related issues: - https://travis-ci.org/cucumber/cucumber-jvm/jobs/244215644 - #1148
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running in parallel the dependency injection context was shared between
scenarios. This made it impossible to run cucumber test with spring without
forking the JVM.
To reduce the resources required to execute a test each thread now will
have its own dependency injection context allowing tests to be executed in
parallel threads.
Related issues:
This fixes #1106
How Has This Been Tested?
Created a unit tests that executes the same cucumber scenario in parallel. The scenario knows it is being executed in parallel and checks if it has not been re-used by any other threads.
Types of changes
Checklist: