Skip to content

Fix NullPointerException at Java8StepDefinition.isDefinedAt #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mpkorstanje
Copy link
Contributor

The api allows StackTraceElement.getFileName()[1] to return null. We
were not able to reproduce this problem reliably but it occurred in
production environments anyway.

Fixes #1217

References:

  1. docs.oracle.com/javase/7/docs/api/java/lang/StackTraceElement.html#getFileName()

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

The api allows `StackTraceElement.getFileName()`[1] to return null. We
were not able to reproduce this problem reliably but it occurred in
production environments anyway.

Fixes #1217

References:
 1. docs.oracle.com/javase/7/docs/api/java/lang/StackTraceElement.html#getFileName()
@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.209% when pulling b577dbc on fix-null-pointer-java8-step-defintion-is-defined-at into fb15952 on master.

@mpkorstanje mpkorstanje merged commit 203a7de into master Sep 13, 2017
@mpkorstanje mpkorstanje deleted the fix-null-pointer-java8-step-defintion-is-defined-at branch September 13, 2017 17:28
brasmusson added a commit that referenced this pull request Sep 14, 2017
@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
@mpkorstanje mpkorstanje restored the fix-null-pointer-java8-step-defintion-is-defined-at branch October 4, 2019 18:18
@mpkorstanje mpkorstanje deleted the fix-null-pointer-java8-step-defintion-is-defined-at branch October 4, 2019 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException at Java8StepDefinition.isDefinedAt
2 participants