fix: changed stack trace list from 3 to 2, to get correct step defin… #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion file name in reports
|
Thanks for the bug report. This must have been broken while refactoring java 8. It appears there is no test for it. |
mpkorstanje
added a commit
that referenced
this pull request
Oct 13, 2017
3 tasks
mlvandijk
pushed a commit
that referenced
this pull request
Oct 26, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ition file name in reports
Summary
In "pretty" reports:
Printing out code locations for step definitions was giving "
NativeConstructorAccessorImpl:-2"
for filename:line_number
instead of the appropriate "step definition filename":line_number output.
This error only happens with Java8/Lambda step definition functions.
Changing 3 to 2, gets the appropriate stacktrace list item to report file and line number.