Skip to content

Print supported languages details #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 22, 2019

Conversation

tsundberg
Copy link
Member

Summary

I updated the language list to include not just the language code but also the language name in English as well as the native language name.

Details

The list of languages looked like this:

af
am
ar
ast
az
bg
…

There are 72 languages supported. It isn't easy to know which language is which.

I extended the list to look like this:

af              Afrikaans                 Afrikaans                   
am              Armenian                  հայերեն                     
ar              Arabic                    العربية                     
ast             Asturian                  asturianu                   
az              Azerbaijani               Azərbaycanca                
bg              Bulgarian                 български                   
…

Motivation and Context

This will make it easier to understand what language a language code is supporting.

How Has This Been Tested?

I added unit tests for calculating the maximum width for each column.
I used inspection to see that the printout looks nice.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…ive name in a three column list.

af              Afrikaans                 Afrikaans
am              Armenian                  հայերեն
ar              Arabic                    العربية
ast             Asturian                  asturianu
az              Azerbaijani               Azərbaycanca
...
@tsundberg
Copy link
Member Author

tsundberg commented Dec 7, 2017

The build fails, the dependency io.cucumber:gherkin:jar:5.0.1-SNAPSHOT is not available.

The error message is:

[ERROR] Failed to execute goal on project cucumber-core: Could not resolve dependencies for project io.cucumber:cucumber-core:jar:2.2.1-SNAPSHOT: Could not find artifact io.cucumber:gherkin:jar:5.0.1-SNAPSHOT in sonatype-snapshots

What can be done about the missing snapshot dependency?

@mpkorstanje
Copy link
Contributor

Once a release is made of the gherkin lib you can use the release version and it should be fine.

@stale
Copy link

stale bot commented Feb 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Feb 12, 2018
@mpkorstanje mpkorstanje added the 🧷 pinned Tells Stalebot not to close this issue label Feb 12, 2018
@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Feb 12, 2018
@tsundberg
Copy link
Member Author

I will redo the implementation and not require a change in Gherkin.

@mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje deleted the print-supported-languages-in-a-three-column-list branch January 5, 2019 02:23
@mpkorstanje mpkorstanje restored the print-supported-languages-in-a-three-column-list branch September 8, 2019 11:55
@mpkorstanje
Copy link
Contributor

Had to do some maintenance on Gherkin v5. This resulted in the name and native name being accessible through getters.

https://github.com/cucumber/cucumber/tree/gherkin/v5.x.x

@mpkorstanje mpkorstanje reopened this Sep 8, 2019
@mpkorstanje mpkorstanje added this to the 5.x.x milestone Sep 8, 2019
@mpkorstanje mpkorstanje modified the milestones: 5.x.x, 5.0.0 Sep 22, 2019
@coveralls
Copy link

coveralls commented Sep 22, 2019

Coverage Status

Coverage decreased (-0.3%) to 87.162% when pulling 8189815 on print-supported-languages-in-a-three-column-list into 1f90854 on master.

@mpkorstanje mpkorstanje changed the title Print supported the languages with their language code, name, and native name Print supported languages details Sep 22, 2019
@mpkorstanje mpkorstanje merged commit a5499df into master Sep 22, 2019
@mpkorstanje mpkorstanje deleted the print-supported-languages-in-a-three-column-list branch September 22, 2019 13:27
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Sep 22, 2019

Cheers @tsundberg! I regret that it took a while to get his done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧷 pinned Tells Stalebot not to close this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants