Add detail to DataTable hint in JavaSnippet and update test #1298
Conversation
| " // E,K,V must be a scalar (String, Integer, Date, enum etc)\n"; | ||
| " // E,K,V must be a scalar (String, Integer, Date, enum etc)\n" + | ||
| " // Make sure the variable names for YourType match the column names\n" + | ||
| " // in your feature file.\n"; |
There was a problem hiding this comment.
I think 'The field names of YourType must match the column names' is better.
Field names instead of variables. The latter exists only in a function. The former is part of a type.
And must instead of make sure because of the rfc.
Not sure about the subject and object. Swapping might be better (if only someone told me learning grammar would allow me to discuss the use of language :) ).
There was a problem hiding this comment.
Updated. Hope this is better.
| @@ -24,7 +24,9 @@ public String arguments(List<Class<?>> argumentTypes) { | |||
| public String tableHint() { | |||
| return " // For automatic transformation, change DataTable to one of\n" + | |||
| " // List<YourType>, List<List<E>>, List<Map<K,V>> or Map<K,V>.\n" + | |||
| " // E,K,V must be a scalar (String, Integer, Date, enum etc)\n"; | |||
| " // E,K,V must be a scalar (String, Integer, Date, enum etc)\n" + | |||
| " // Field names for YourType must match the column names in \n" + | |||
There was a problem hiding this comment.
I found some code that suggests the field name don't need to be an exact match.
My Field, and myField will all match myField.
There was a problem hiding this comment.
The PascalCaseStringConverter btw.
There was a problem hiding this comment.
And also CamelCaseStringConverter.
So my Field will probably also work.
There was a problem hiding this comment.
Thanks, I'll have a look and rewrite a little to make this clear.
…e-hint # Conflicts: # java/src/test/java/cucumber/runtime/java/JavaSnippetTest.java
|
Changes Unknown when pulling 8eb47a8 on mlvandijk:datatable-hint into ** on cucumber:master**. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Add detail to DataTable hint in JavaSnippet to mention that variable names of domain object ("YourType") need to match column names in the feature file.
Details
Motivation and Context
First use of DataTable didn't quite work as expected (see #1297).
This hint may be helpful to others.
How Has This Been Tested?
Unit test for JavaSnippet was updated accordingly.
'mvn clean install' built successfully.
Screenshots (if appropriate):
Types of changes
Checklist: