Remove scenario scoped step definitions from step definition cache #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in cucumber 2.3.0 where the cache would serve up a lambda step definition from a previous step.
Features used by cucumber-java8, specifically glue coded step definitions, were not used in integration tests. Adding these should allow us to discover java8 related problems quicker.
mpkorstanje
force-pushed
the
fix-use-of-stale-glue
branch
from
22b0221 to
2381174
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove scenario scoped step definitions from step definition cache This fixes a bug in cucumber 2.3.0 where the cache would serve up a lambda step definition from a previous step.
How Has This Been Tested?
Added a unit test and java8 examples. Features used by cucumber-java8, specifically glue coded step
definitions, were not used in integration tests. Adding these should allow us to discover java8 related problems quicker.
Types of changes
Checklist: