-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[Core] Add object-factory option to CLI and CucumberOptions #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
corrected. Test added.
annotations in core, junit and testng. Tests added.
core/src/main/java/io/cucumber/core/options/RuntimeOptionsParser.java
Outdated
Show resolved
Hide resolved
junit/src/main/java/io/cucumber/junit/JUnitCucumberOptionsProvider.java
Outdated
Show resolved
Hide resolved
core/src/test/java/io/cucumber/core/options/CucumberPropertiesParserTest.java
Outdated
Show resolved
Hide resolved
Cheers looks good. Just a few small things. |
I have made the requested changes. I think the PR is ready. Maybe at some point in the future someone should write a short abstract on how to use object factories in v5. |
Cheers!
You wouldn't be happen to volunteer? It doesn't need to be a full blown doc. A short brief in a readme of the core module will do. |
As requested -> #1715 |
Co-authored-by: Renovate Bot <[email protected]>
Summary
In order to provide different test configurations it might be useful to use different object factories when working with a DI framework. This is described in issue #1690.
Details
Motivation and Context
cucumber.properties
.META-INF/services/io.cucumber.core.backend.ObjectFactory
. Multiple implementations can be given here.How Has This Been Tested?
Unit tests have been added and a production test has been executed with our product.
Types of changes
Checklist: