Skip to content

[Core] Remove gherkin from public and internal api #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 17, 2019

Conversation

mpkorstanje
Copy link
Contributor

Summary

Removes all gherkin related classes from the public and internal APIs
This ensures that a future Gherkin update will only impact a limited
section of cucumber

Because the information from pickles, and features still need to be
accessed it wrapped in our own API. This also makes it possible to
provide access to a steps keyword. This in turn removes the
**keyword** from the snippet suggested events allowing them to
be used directly.

By including the snippet suggestion each time a test fails because a
step is undefined test runners that group output per test case can
clearly document which steps need to be implemented for each scenario.

This will allow users to use Cucumber JUnit without including the
summary plugin. Allowing a bit more configuration to be replaced by
defaults.

Screenshots (if appropriate):

IDEA collects stdout output and groups displays it per unit test:

image

Maven does the same thing per JUnit test case:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Removes all `gherkin` related classes from the public and internal APIs
This ensures that a future Gherkin update will only impact a limited
section of cucumber.
By including the snippet suggestion each time a test fails because a
step is undefined test runners that group output per test case can
clearly document which steps need to be implemented for each scenario.

This will allow users to use Cucumber JUnit without including the
summary plugin. Allowing a bit more configuration to be replaced by
defaults.
@mpkorstanje mpkorstanje added this to the 5.0.0 milestone Aug 17, 2019
@mpkorstanje mpkorstanje merged commit 97d913b into master Aug 17, 2019
@mpkorstanje mpkorstanje deleted the remove-gherkin-from-public-and-internal-api branch August 17, 2019 20:30
mpkorstanje added a commit that referenced this pull request Aug 22, 2019
Implements #1740 for TestNG. By including the snippet suggestion
each time a test fails because a step is undefined test runners that
group output per test case can clearly document which steps need
to be implemented for each scenario.

This will allow users to use Cucumber JUnit without including the
summary plugin. Allowing a bit more configuration to be replaced by
defaults.
@mpkorstanje mpkorstanje restored the remove-gherkin-from-public-and-internal-api branch October 4, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant