[Core] Remove gherkin from public and internal api #1740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes all
gherkin
related classes from the public and internal APIsThis ensures that a future Gherkin update will only impact a limited
section of cucumber
Because the information from pickles, and features still need to be
accessed it wrapped in our own API. This also makes it possible to
provide access to a steps keyword. This in turn removes the
**keyword**
from the snippet suggested events allowing them tobe used directly.
By including the snippet suggestion each time a test fails because a
step is undefined test runners that group output per test case can
clearly document which steps need to be implemented for each scenario.
This will allow users to use Cucumber JUnit without including the
summary plugin. Allowing a bit more configuration to be replaced by
defaults.
Screenshots (if appropriate):
IDEA collects stdout output and groups displays it per unit test:
Maven does the same thing per JUnit test case:
Types of changes
Checklist: