[Core] Rework backend #1776
Merged
[Core] Rework backend #1776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the backend module. With this module backend implementations only need to use dependencies from `io.cucumber.core.backend`. This will allow us to introduce the module system later on. This required duplication of the invoker and status classes but as these relatively simple (after deprecation) this duplication is ok. It is also worth noting that the invokers for Java8 and Java are notably different. The common concern, providing proper exception messages has been pushed up to core. Fixes #1386
mpkorstanje
force-pushed
the
rework-backend
branch
from
7c42cad to
ee1bc06
Compare
Prefer using library based solutions * [JUnit 5 `Assertions.assertTimeout*`](https://junit.org/junit5/docs/5.0.1/api/org/junit/jupiter/api/Assertions.html#assertTimeout-java.time.Duration-org.junit.jupiter.api.function.Executable-) * [Awaitility](https://github.com/awaitility/awaitility) * [Guava `TimeLimiter`](https://github.com/google/guava/blob/master/guava/src/com/google/common/util/concurrent/TimeLimiter.java)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the backend module. With this module backend
implementations only need to use dependencies from
io.cucumber.core.backend. This will allow us to introduce themodule system later on
The implementation is not yet perfect. Classpath scanning and
resource loading is located in other modules. Removing this
depends on #1526 and removal of type registry configurer which
depends on #1768 .
Fixes #1386 because steps can now see if an exception came from
user code or actual backend.
Removes timeout which would close #1695 earlier then expected.
Types of changes
Checklist: