[Core] Indent write events in PrettyFormatter #1809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2019 14:09
mpkorstanje
reviewed
Oct 17, 2019
mpkorstanje
reviewed
Oct 17, 2019
core/src/main/java/cucumber/runtime/formatter/PrettyFormatter.java
Outdated
Show resolved
Hide resolved
added 2 commits
October 17, 2019 15:11
mpkorstanje
reviewed
Oct 17, 2019
core/src/main/java/cucumber/runtime/formatter/PrettyFormatter.java
Outdated
Show resolved
Hide resolved
mpkorstanje
reviewed
Oct 17, 2019
core/src/main/java/cucumber/runtime/formatter/PrettyFormatter.java
Outdated
Show resolved
Hide resolved
|
Had to manually merge this because your repo was lagging behind Cucumber JVM quite a bit. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add indentation to PrettyFormatter
Motivation and Context
As @mpkorstanje said in #1784 , scenario.write() ignores the steps indentation so it doesn't look so pretty.