[Core] Replace ResourceIterable with standard Java solutions #1820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mpkorstanje
force-pushed
the
refactor-resource-loading
branch
from
e2b5041 to
aacd9b9
Compare
`ResourceIterable` provides inconsistent support for URI's. Supported: * file:path/to.feature * classpath:com/example.feature * classpath:features.jar#!com/example.feature Unsupported: * jar:path/to.jar#!/com/example.feature * any-jvm-supported-file-system:path/to.feature Replacing `ResourceIterable` with `FileSystem` and `Path` adds consistent support for URI's and reduces the complexity of scanning for classes and resources significantly. Both `ClasspathScanner` and `ResourceScanner` are instantiated with a ClassLoader for all class path operations. This should allow Cucumber access to platforms use fat jars and other packaging methods. Fixes: #1526
mpkorstanje
force-pushed
the
refactor-resource-loading
branch
3 times, most recently
from
3bea34a to
89a634e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ResourceIterableprovides inconsistent support for URI's.Supported:
Unsupported:
Replacing
ResourceIterablewith an implementation that usesFileSystemandPathadds consistent support for URI'sand reduces the complexity of scanning for classes and
resources significantly.
Both
ClasspathScannerandResourceScannerare instantiated with aClassLoader for all class path operations. This should allow Cucumber
access to platforms use fat jars and other packaging methods.
Fixes: #1526
Types of changes
Checklist: