[Spring] Do not reuse generic application context between scenarios #1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When neither a glue class with a spring context configuration could be found nor a `cucumber.xml` file exists `cucumber-spring` will fall back to a `GenericApplicationContext` to facilitate dependency injection. The current implementation tries to reuse this application context between scenarios. This requires refreshing the context which can only be done once. So it's not possible to reuse the `GenericApplicationContext` and a new one should be created for each scenario.
mpkorstanje
deleted the
fix-generic-application-context-cant-re-reused
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When neither a glue class with a spring context configuration could be found
nor a
cucumber.xmlfile existscucumber-springwill fall back to aGenericApplicationContextto facilitate dependency injection.The current implementation tries to reuse this application context between
scenarios. This requires refreshing the context which can only be done once.
So it's not possible to reuse the
GenericApplicationContextand a new oneshould be created for each scenario.
Motivation and Context
https://stackoverflow.com/questions/60445228/cucumber-5-0-0-and-springboot-multiple-scenarios-in-one-feature-file
How Has This Been Tested?
Because
cucumber.xmland theGenericApplicationContextare fallback methods it is very hard to test these individually. Had to test these manually using:https://github.com/mpkorstanje/cucumber-spring-1905
Types of changes
Checklist: