Skip to content

[Java8] update to net.jodah:typetools:0.6.2 #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

nhojpatrick
Copy link
Member

Summary

Upgrade net.jodah:typetools from 0.6.1 to 0.6.2, which includes Automatic-Module-Name, that can be used for jpms.

Details

Dependency update for java8 pom

Motivation and Context

Getting Java Modules working for cucumber, so doing pr's for downstream projects.

How Has This Been Tested?

mvn clean install

Screenshots (if appropriate):

n/a/

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@nhojpatrick nhojpatrick requested a review from mpkorstanje March 3, 2020 11:33
@mpkorstanje mpkorstanje changed the title [java8] update to net.jodah:typetools:0.6.2 [Java8] update to net.jodah:typetools:0.6.2 Mar 3, 2020
@mpkorstanje mpkorstanje merged commit 4d98e02 into master Mar 3, 2020
@mpkorstanje mpkorstanje deleted the bugfix/net.jodah_typetools_v0.6.2 branch March 3, 2020 11:34
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Mar 3, 2020

Cheers. I've already add multi-release capabilities to the build. See: https://github.com/cucumber/cucumber-jvm/tree/master/junit-platform-engine/src/main/java9

But because we're still shading quite a few things I would suggest we start by adding module information to the leaf projects. E.g: cucumber-java, cucumber-java8, cucumber-junit, ect.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.057% when pulling a1fc559 on bugfix/net.jodah_typetools_v0.6.2 into 3b56c93 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants